Make storage per-runtime #2494
Merged
Make storage per-runtime #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
2 times, most recently
from
bb03e71 to
a8ba992
Compare
Codecov Report
@@ Coverage Diff @@
## master #2494 +/- ##
==========================================
+ Coverage 66.86% 66.86% +<.01%
==========================================
Files 324 325 +1
Lines 29894 29937 +43
==========================================
+ Hits 19988 20018 +30
- Misses 7413 7415 +2
- Partials 2493 2504 +11
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
3 times, most recently
from
98e8b68 to
6456f08
Compare
ptrus
reviewed
Dec 23, 2019
ptrus
approved these changes
Dec 23, 2019
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
from
6456f08 to
4ea72c1
Compare
As mentioned on Slack (and in the changelog fragment), the main point for doing this is to simplify the storage database schema, so per-key namespacing is no longer required. It also makes it simpler to remove or copy data for a specific runtime. |
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
2 times, most recently
from
24fc863 to
23cbfee
Compare
This commit removes the global node storage backend and instead replaces it with per-runtime storage backends. To support answering queries for multiple runtimes via gRPC a runtime registry-based storage router is added.
Since the expected usage is now to create a storage client for each runtime (namespace), the client can be simplified to only support tracking a single runtime.
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
from
23cbfee to
dbb0c72
Compare
|
Do we want to reduce the storage cache sizes (or make it configurable)? |
|
Good idea, I'll make it configurable. |
Yawning
approved these changes
Dec 27, 2019
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
2 times, most recently
from
7c3866a to
90b1f32
Compare
kostko
force-pushed
the
kostko/feature/storage-per-rt
branch
from
90b1f32 to
067af88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2474
This PR changes database file organization within the node data directory and storage database internals and as such it is BREAKING WITHOUT MIGRATION.
TODO