Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node: Remove the debug dummy sub-commands #2492

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Dec 19, 2019

Fixes #1471

These are only useful for testing, and our test harness has a internal
Go API that removes the need to have this functionality exposed as a
subcommand.

@Yawning Yawning added the c:cli Category: command line interface label Dec 19, 2019
@Yawning Yawning self-assigned this Dec 19, 2019
These are only useful for testing, and our test harness has a internal
Go API that removes the need to have this functionality exposed as a
subcommand.
@Yawning Yawning force-pushed the yawning/feature/1471 branch from 1fbe8fe to b1bd66e Compare December 19, 2019 08:28
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #2492 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
+ Coverage   67.33%   67.48%   +0.15%     
==========================================
  Files         322      321       -1     
  Lines       29809    29768      -41     
==========================================
+ Hits        20071    20090      +19     
+ Misses       7292     7231      -61     
- Partials     2446     2447       +1
Impacted Files Coverage Δ
go/oasis-node/cmd/debug/debug.go 100% <ø> (ø) ⬆️
go/worker/compute/committee/state.go 74.07% <0%> (-11.12%) ⬇️
go/worker/common/p2p/p2p.go 62.61% <0%> (-8.56%) ⬇️
go/common/cbor/codec.go 64.7% <0%> (-5.89%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0%> (-5.23%) ⬇️
go/worker/compute/committee/node.go 61.97% <0%> (-4.63%) ⬇️
go/worker/common/committee/group.go 80.07% <0%> (-2.26%) ⬇️
go/consensus/tendermint/abci/mux.go 67.39% <0%> (-0.73%) ⬇️
go/roothash/api/commitment/pool.go 70.91% <0%> (-0.6%) ⬇️
go/storage/client/client.go 70.65% <0%> (+0.72%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17735a...b1bd66e. Read the comment docs.

@Yawning Yawning merged commit 9b309de into master Dec 19, 2019
@Yawning Yawning deleted the yawning/feature/1471 branch December 19, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go/ekiden: Rename debug dummy sub-command and dummydebug module
2 participants