Expose consensus blocks and scheduler API via internal gRPC #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/consensus-accessors
branch
from
1fdbfdd to
e79af06
Compare
Codecov Report
@@ Coverage Diff @@
## master #2484 +/- ##
==========================================
+ Coverage 66.99% 67.07% +0.08%
==========================================
Files 321 323 +2
Lines 29503 29761 +258
==========================================
+ Hits 19765 19962 +197
- Misses 7304 7324 +20
- Partials 2434 2475 +41
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/consensus-accessors
branch
5 times, most recently
from
025c8d2 to
f35116e
Compare
kostko
changed the title
Yawning
reviewed
Dec 19, 2019
kostko
force-pushed
the
kostko/feature/consensus-accessors
branch
from
f35116e to
c9e8ead
Compare
Yawning
approved these changes
Dec 19, 2019
kostko
force-pushed
the
kostko/feature/consensus-accessors
branch
from
c9e8ead to
eb6965c
Compare
ptrus
reviewed
Dec 19, 2019
ptrus
reviewed
Dec 19, 2019
Apparently Tendermint's pubsub can return a nil subscription and a nil error when the node is just shutting down while subscribe is being called. Do something more sensible and return context.Canceled in this case instead of dereferencing a nil pointer.
The default is 1 GiB per badger instance and we use a few instances so this resulted in some nice memory usage.
kostko
force-pushed
the
kostko/feature/consensus-accessors
branch
from
eb6965c to
49040b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2482
TODO