Temporarily disable p2p id checks (for public testnet upgrade) #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjgilbert
force-pushed
the
peterjgilbert/test/disable_p2p_checks
branch
from
2d7acfd to
97afd9b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2468 +/- ##
=========================================
- Coverage 67.52% 67.5% -0.02%
=========================================
Files 307 307
Lines 30100 30091 -9
=========================================
- Hits 20324 20312 -12
- Misses 7299 7301 +2
- Partials 2477 2478 +1
Continue to review full report at Codecov.
|
peterjgilbert
changed the title
peterjgilbert
force-pushed
the
peterjgilbert/test/disable_p2p_checks
branch
from
97afd9b to
af6600b
Compare
|
I'm moderately opposed to this out of principle, but if migration is required then I suppose there's no other option. Can you make an issue to revert the removal of the checks so that we do not forget? |
Yawning
approved these changes
Dec 16, 2019
No need to merge this one. We will do the testnet redeploy from branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2428. For compatibility with dumps from networks running pre-#2424 versions of oasis-node, we need to accept 0-valued p2p ids.