common/cbor: Add debug.strict_cbor
#2258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
added
c:testing
Yawning
force-pushed
the
yawning/feature/checked-cbor
branch
from
bb1f4f5 to
5b0fb39
Compare
kostko
approved these changes
Oct 14, 2019
| @@ -56,3 +89,9 @@ func MustUnmarshal(data []byte, dst interface{}) { | |||
| panic(err) | |||
| } | |||
| } | |||
|
|
|||
| func init() { | |||
| Flags.Bool(CfgDebugStrictCBOR, false, "(DEBUG) Enforce that CBOR blobs roundtrip") | |||
There was a problem hiding this comment.
Maybe make the flag hidden from --help?
Yawning
force-pushed
the
yawning/feature/checked-cbor
branch
from
5b0fb39 to
8e8625d
Compare
|
I'm not sure if this is workable. A lot of things fail because we have |
We might as well add round-trip sanity checking, at least when we are testing things. I'm not sure if this should be enabled all the time, and it is written under the assumption that it is not, as round-trip failures will crash the node if the flag is enabled.
Yawning
force-pushed
the
yawning/feature/checked-cbor
branch
from
030b670 to
837a9c4
Compare
|
Yeah, I'm going to give up on this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might as well add round-trip sanity checking, at least when we are
testing things. I'm not sure if this should be enabled all the time,
and it is written under the assumption that it is not, as round-trip
failures will crash the node if the flag is enabled.
Inspired by #2020