runtime: Verify read/write sets during transaction execution

[kostko]

Fixes #2012.
Based on #2054.

TODO

• Add/update tests.

[codecov]

Codecov Report

Merging #2081 into kostko/feature/storage-rs-v2 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                       Coverage Diff                        @@
##           kostko/feature/storage-rs-v2    #2081      +/-   ##
================================================================
- Coverage                          53.5%   53.48%   -0.02%     
================================================================
  Files                               266      266              
  Lines                             25687    25687              
================================================================
- Hits                              13743    13739       -4     
- Misses                            10479    10482       +3     
- Partials                           1465     1466       +1

Impacted Files	Coverage Δ
go/scheduler/tendermint/tendermint.go	64.28% <0%> (-4.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb1b4d...5595d43. Read the comment docs.

[codecov]

Codecov Report

Merging #2081 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2081   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files         267      267           
  Lines       26331    26331           
=======================================
  Hits        13886    13886           
  Misses      10984    10984           
  Partials     1461     1461

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cb892...ecd5707. Read the comment docs.

[Yawning]

I'd feel better about approving this if I understood the storage code in more depth.

[kostko]

I did some more thinking on this and I think this also needs support for some runtime-specific integration (hooks for handling reverts and accessing the read/write set so that its hash can be included with the signed transaction).

[kostko]

My concerns are the following (points added to the agenda for the next design meeting):

• What should happen when the specified read/write set is invalid? The current implementation will just revert all the storage side-effects of the whole transaction which is safe but may be a DoS vector as the revert doesn’t cost any gas.
  • In case it needs to do gas accounting, this could also violate the read/write set or should that be excluded?
  • Excluding it would only be possible if we could make sure that the gas accounting operations can't introduce conflicts (related to Runtime gas disbursement #2071 and special atomic storage operations).
• Read/write sets probably need to be authenticated by the caller (transaction signer) if they can cost the caller gas.

[kostko]

Deprioritized.