ias: Access control #2018
Merged
ias: Access control #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
added
p:1
Yawning
force-pushed
the
yawning/feature/runtime-tee-version
branch
7 times, most recently
from
07abec4 to
6fc2622
Compare
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
=========================================
- Coverage 55.97% 53.97% -2%
=========================================
Files 247 242 -5
Lines 25089 23743 -1346
=========================================
- Hits 14043 12815 -1228
- Misses 9534 9545 +11
+ Partials 1512 1383 -129
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
==========================================
- Coverage 55.46% 54.96% -0.51%
==========================================
Files 250 255 +5
Lines 25245 25537 +292
==========================================
+ Hits 14002 14036 +34
- Misses 9722 9977 +255
- Partials 1521 1524 +3
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/runtime-tee-version
branch
15 times, most recently
from
67f78ef to
951c88a
Compare
Yawning
force-pushed
the
yawning/feature/runtime-tee-version
branch
6 times, most recently
from
909c945 to
563e134
Compare
If you are going to do a dump/restore, actually migrating the keymanager database is probably a good idea.
* Instead of a mountain of args, this now takes a `Config` struct * The attestation related worker host routines now live in a separate interface.
The IAS proxy also needs to deal with TLS certificates.
10 mins to run the go CI tests is excessive, and this test appears to blame. Running the profiler shows that the GC is going crazy, due to a combination of snappy and go-codec (probably to be expected), and the CI host has less resources than typical development hosts.
* Move the mock AVR generator to `common/sgx/ias` * Add `ias.debug.skip_verify` since using the env var for configuration there is weird and inconsistent. Breaking due to: * Env var being replaced with a config option.
This also will enable the IAS proxy, in mock mode for the e2e tests when SGX is configured if `EKIDEN_UNSAFE_SKIP_VERIFY` is set.
This is now a struct so that MRSIGNER/MRENCLAVE pairs (and etc) can also be included.
* Ability to bypass auth (for easy testing/development) * Ability to just use a genesis document (for easy testing/development)
Currently mostly pointless, using the genesis file is easier and more lightweight. But this is the "right" way to do things, assuming runtimes can be registered/updated without a redeploy.
Yawning
force-pushed
the
yawning/feature/runtime-tee-version
branch
from
563e134 to
0d2ba3c
Compare
pro-wh
approved these changes
Aug 28, 2019
ravenac95
approved these changes
Aug 28, 2019
peterjgilbert
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix #1998, #1843 (partial).
go/worker/compute: Defer runtime registration till Start().(This causes mountains of pain, revisit)Limit attestations to compute/keymanager nodes.(Moved to followup issue registry: Node registration process should be 2 stage #2039)Enforce MRENCLAVE/MRSIGNER validity (worker host)?(Unrelated to IAS)Breaking due to:
--ias.debug.skip_verifyused in favor ofEKIDEN_UNSAFE_SKIP_AVR_VERIFYat runtime.--runtime.version.enclaverequired when provisioning runtimes, unless IAS proxy authentication is disabled. The ability to omit this flag may go away in the near future.--genesis_file->--genesis.filewhen provisioning the genesis file.--ias.tlsis required for workers that wish to use the IAS proxy.