-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tendermint state follower #1916
Conversation
While you're here and messing with the dependency system, can you change the enforcement to happen in the Rationale: Being less dependent on initialization order is a good thing, and at some point we may even want dependency loops (though this will require other refactoring). |
ok |
665108c
to
77e3cbe
Compare
It sounds like one thing we should settle on here is what specific byzantine behavior and tests we want to run regularly with the use of this code. Do we have thoughts on what we want to scope in / out for the first pass? |
edit: found it https://docs.google.com/document/d/1xD04oeqvuQ64tocD6ou0E1AHbjHteJqoEzfqoyNcgqE/edit thx :) |
53a7766
to
b7afdc2
Compare
857e03f
to
a96a087
Compare
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
- Coverage 53.96% 53.78% -0.19%
==========================================
Files 242 244 +2
Lines 23733 23726 -7
==========================================
- Hits 12807 12760 -47
- Misses 9544 9596 +52
+ Partials 1382 1370 -12
Continue to review full report at Codecov.
|
a96a087
to
ec74df8
Compare
At this point, the PR has been scoped down to just the tendermint follower, which all the main idea is already coded up, so reviewers can start taking a look. It's still broken though, with the benign Tendermint node not syncing with the network. It's something I'm doing wrong when trying to set it up. Some debugging code remains too. |
ec74df8
to
803e9ff
Compare
be5a07b
to
5f810cd
Compare
7c449d9
to
f65a5d8
Compare
f65a5d8
to
e20f12e
Compare
we now propagate errors. it's mostly converted from panics, so steps might not leave the process in a very good state when they fail |
After reviewing #1959 I guess some of the new/start separation could be done here. |
e20f12e
to
98785a6
Compare
updates:
|
98785a6
to
35d3d63
Compare
// GetEpochBlock implements epochtime Backend. | ||
func (*fakeTimeBackend) GetEpochBlock(ctx context.Context, epoch api.EpochTime) (int64, error) { | ||
panic("GetEpochBlock not supported") | ||
// return int64(epoch) * 30, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya ok
35d3d63
to
e46d5a2
Compare
e46d5a2
to
7060382
Compare
This has the passive Tendermint state follower for use in the Byzantine node.
blocks #1936
also has the start of the Byzantine node subcommand