Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make oasis-net-runner default fixtures more useful #4902

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

matevz
Copy link
Member

@matevz matevz commented Aug 23, 2022

This PR makes oasis-net-runner defaults more tailored to local (dApp) development and debugging:

  • increases balance of test account to 10^15 base units (1 million TEST)
  • sets max_allowances to 16 in order to make deposits to runtimes possible without passing a separate staking genesis fixture

Related oasis-sdk PR: oasisprotocol/oasis-sdk#1081

@matevz matevz changed the title Matevz/feature/make test account useful make oasis-net-runner default fixtures more useful Aug 23, 2022
@matevz matevz force-pushed the matevz/feature/make-test-account-useful branch 2 times, most recently from a79bb78 to 61d1f78 Compare August 24, 2022 13:18
@matevz matevz force-pushed the matevz/feature/make-test-account-useful branch 3 times, most recently from 5169f40 to 48ead79 Compare August 26, 2022 12:22
@matevz matevz force-pushed the matevz/feature/make-test-account-useful branch from 48ead79 to 71aed06 Compare August 29, 2022 10:26
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4902 (48ead79) into master (7fa7883) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 48ead79 differs from pull request most recent head 71aed06. Consider uploading reports for the commit 71aed06 to get more accurate results

@@            Coverage Diff             @@
##           master    #4902      +/-   ##
==========================================
+ Coverage   66.60%   66.66%   +0.06%     
==========================================
  Files         464      464              
  Lines       50977    50977              
==========================================
+ Hits        33954    33986      +32     
+ Misses      12833    12815      -18     
+ Partials     4190     4176      -14     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/genesis/staking.go 69.86% <0.00%> (ø)
go/consensus/tendermint/apps/staking/auth.go 62.96% <0.00%> (-14.82%) ⬇️
go/common/grpc/auth/auth.go 94.73% <0.00%> (-5.27%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
go/common/logging/zap.go 62.58% <0.00%> (-2.88%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 65.81% <0.00%> (-2.57%) ⬇️
go/runtime/host/multi/multi.go 70.58% <0.00%> (-2.21%) ⬇️
go/consensus/api/submission.go 60.86% <0.00%> (-2.18%) ⬇️
go/storage/mkvs/lookup.go 77.08% <0.00%> (-2.09%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matevz matevz enabled auto-merge August 29, 2022 10:27
@matevz matevz merged commit 298de9f into master Aug 29, 2022
@matevz matevz deleted the matevz/feature/make-test-account-useful branch August 29, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants