Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus layer state access from runtimes #3823

Merged
merged 5 commits into from
Apr 16, 2021

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 30, 2021

Fixes: #3564

TODO:

@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch from 254d0c0 to e81acba Compare March 30, 2021 16:17
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to also add a check to protocol.rs (where RuntimeInfoRequest is handled) to make sure that the Tendermint consensus backend is in use.

runtime/src/common/key_format.rs Outdated Show resolved Hide resolved
runtime/src/common/key_format.rs Outdated Show resolved Hide resolved
runtime/src/consensus/state/staking.rs Outdated Show resolved Hide resolved
runtime/src/consensus/state/staking.rs Outdated Show resolved Hide resolved
runtime/src/consensus/state/staking.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch 2 times, most recently from e4fde64 to 79cb36f Compare March 30, 2021 19:34
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #3823 (f2912f8) into master (d4a97fa) will decrease coverage by 0.19%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3823      +/-   ##
==========================================
- Coverage   67.10%   66.91%   -0.20%     
==========================================
  Files         404      404              
  Lines       41463    41467       +4     
==========================================
- Hits        27825    27746      -79     
- Misses       9698     9765      +67     
- Partials     3940     3956      +16     
Impacted Files Coverage Δ
go/common/version/version.go 75.00% <ø> (ø)
...o/consensus/tendermint/apps/staking/state/state.go 61.62% <ø> (ø)
go/runtime/host/protocol/types.go 42.85% <ø> (ø)
go/runtime/host/protocol/connection.go 60.97% <25.00%> (ø)
go/runtime/client/client.go 66.10% <50.00%> (-0.34%) ⬇️
go/runtime/host/helpers.go 56.75% <100.00%> (+1.20%) ⬆️
go/runtime/registry/config.go 67.59% <100.00%> (ø)
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/runtime/host/sandbox/sandbox.go 69.53% <0.00%> (-10.55%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a97fa...f2912f8. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch 14 times, most recently from 3f05c0c to 9912720 Compare April 1, 2021 16:02
runtime/src/common/version.rs Outdated Show resolved Hide resolved
runtime/src/protocol.rs Outdated Show resolved Hide resolved
runtime/src/consensus/state/staking.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch 7 times, most recently from 03a2542 to a56ceb1 Compare April 2, 2021 11:56
@ptrus ptrus marked this pull request as ready for review April 2, 2021 11:58
@ptrus ptrus requested a review from Yawning as a code owner April 2, 2021 11:58
@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch from a56ceb1 to 58aca68 Compare April 5, 2021 10:17
runtime/src/protocol.rs Outdated Show resolved Hide resolved
runtime/src/storage/mkvs/mod.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch 3 times, most recently from 9e5018f to f60f796 Compare April 15, 2021 10:12
@ptrus ptrus requested a review from kostko April 15, 2021 16:22
go/runtime/host/protocol/types.go Outdated Show resolved Hide resolved
runtime/src/consensus/state/staking.rs Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch from f60f796 to 7181148 Compare April 16, 2021 08:04
@ptrus ptrus force-pushed the ptrus/feature/consensus-runtime branch from 7181148 to f2912f8 Compare April 16, 2021 08:06
@ptrus ptrus merged commit 209a89c into master Apr 16, 2021
@ptrus ptrus deleted the ptrus/feature/consensus-runtime branch April 16, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic consensus layer state accessors for Rust
2 participants