Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/version: Bump consensus protocol version to 2.0.0 #3470

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Nov 3, 2020

Since #3360 has been merged, we stated that from now onwards, only a change in a protocol's major version signifies a backward-incompatible change.

The change in #3458 is a breaking change, hence we should bump the consensus protocol's major version.

Since #3360 has been
merged, we stated that from now onwards, only a change in a protocol's
major version signifies a backward-incompatible change.

The change in #3458 is
a breaking change, hence we should bump the consensus protocol's major
version.
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #3470 into stable/20.12.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           stable/20.12.x    #3470      +/-   ##
==================================================
+ Coverage           65.60%   65.62%   +0.01%     
==================================================
  Files                 370      370              
  Lines               33349    33349              
==================================================
+ Hits                21880    21885       +5     
+ Misses               8262     8257       -5     
  Partials             3207     3207              
Impacted Files Coverage Δ
go/common/version/version.go 78.94% <ø> (ø)
go/storage/mkvs/writelog/iterator.go 72.72% <0.00%> (-18.19%) ⬇️
go/common/grpc/errors.go 79.06% <0.00%> (-9.31%) ⬇️
go/worker/common/committee/runtime_host.go 62.88% <0.00%> (-5.16%) ⬇️
go/runtime/tagindexer/tagindexer.go 66.27% <0.00%> (-4.66%) ⬇️
go/storage/mkvs/iterator.go 79.13% <0.00%> (-4.32%) ⬇️
go/storage/mkvs/prefetch.go 54.71% <0.00%> (-3.78%) ⬇️
go/worker/storage/service_external.go 44.44% <0.00%> (-3.71%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 72.41% <0.00%> (-3.45%) ⬇️
go/worker/storage/committee/node.go 71.42% <0.00%> (-2.86%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29561ef...f859205. Read the comment docs.

@tjanez tjanez merged commit 46a8dcd into stable/20.12.x Nov 3, 2020
@tjanez tjanez deleted the tjanez/bump-consensus-version branch November 3, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants