Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/genesis: Add check for canonical form to check command & Docs #3298

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Sep 21, 2020

Partially extracted from #3290.

@tjanez tjanez added c:docs Category: documentation c:cli Category: command line interface labels Sep 21, 2020
docs/oasis-node/cli.md Outdated Show resolved Hide resolved
@tjanez tjanez force-pushed the tjanez/genesis-misc branch from e3c4300 to bf6f14f Compare September 21, 2020 13:06
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #3298 into master will decrease coverage by 0.05%.
The diff coverage is 8.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3298      +/-   ##
==========================================
- Coverage   65.11%   65.06%   -0.06%     
==========================================
  Files         371      371              
  Lines       33016    33039      +23     
==========================================
- Hits        21500    21497       -3     
- Misses       8335     8357      +22     
- Partials     3181     3185       +4     
Impacted Files Coverage Δ
go/oasis-node/cmd/genesis/genesis.go 50.12% <8.69%> (-1.44%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.38% <0.00%> (-19.24%) ⬇️
go/worker/compute/executor/committee/state.go 71.42% <0.00%> (-14.29%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 78.94% <0.00%> (-10.53%) ⬇️
go/worker/common/committee/runtime_host.go 62.88% <0.00%> (-5.16%) ⬇️
go/runtime/host/protocol/connection.go 56.37% <0.00%> (-4.94%) ⬇️
go/staking/api/grpc.go 49.57% <0.00%> (-1.69%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 49.19% <0.00%> (-1.62%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 46.37% <0.00%> (-1.45%) ⬇️
go/consensus/tendermint/roothash/roothash.go 70.15% <0.00%> (-1.24%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb2b88f...9250cab. Read the comment docs.

@tjanez tjanez force-pushed the tjanez/genesis-misc branch from bf6f14f to 1f19006 Compare September 21, 2020 13:47
@tjanez tjanez force-pushed the tjanez/genesis-misc branch from 1f19006 to 9250cab Compare September 21, 2020 15:07
@tjanez tjanez merged commit f19387e into master Sep 21, 2020
@tjanez tjanez deleted the tjanez/genesis-misc branch September 21, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:docs Category: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants