Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/extra/stats: remove the unmaintained extra/stats tool #3270

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Sep 14, 2020

The extra/stats tool is not used anymore and is not being kept up-to-date with oasis-core updates.

@ptrus ptrus force-pushed the ptrus/internal/remove-extra-stats branch 2 times, most recently from 558dede to e736d7b Compare September 14, 2020 08:17
@ptrus ptrus force-pushed the ptrus/internal/remove-extra-stats branch from e736d7b to 06d97cc Compare September 14, 2020 09:02
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #3270 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3270      +/-   ##
==========================================
+ Coverage   67.70%   67.88%   +0.18%     
==========================================
  Files         371      371              
  Lines       36874    36874              
==========================================
+ Hits        24965    25032      +67     
+ Misses       8724     8682      -42     
+ Partials     3185     3160      -25     
Impacted Files Coverage Δ
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/common/grpc/errors.go 78.26% <0.00%> (-10.87%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 85.71% <0.00%> (-7.94%) ⬇️
go/storage/metrics.go 80.76% <0.00%> (-3.85%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 81.03% <0.00%> (-3.45%) ⬇️
go/storage/api/root_cache.go 77.77% <0.00%> (-3.18%) ⬇️
go/keymanager/client/client.go 84.29% <0.00%> (-2.48%) ⬇️
go/worker/common/committee/node.go 75.48% <0.00%> (-2.41%) ⬇️
go/consensus/api/grpc.go 68.27% <0.00%> (-2.27%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2207b9c...06d97cc. Read the comment docs.

@ptrus ptrus merged commit 5a760da into master Sep 14, 2020
@ptrus ptrus deleted the ptrus/internal/remove-extra-stats branch September 14, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants