Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go staking: increase reward amount denominator #3065

Merged
merged 3 commits into from
Jun 29, 2020
Merged

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Jun 29, 2020

The denominator turned out not to be fine enough. This PR increases it. To keep the same reward rate, the numerators from the genesis block would need to be increased too. cc @bennetyee

@pro-wh
Copy link
Contributor Author

pro-wh commented Jun 29, 2020

This new value 100_000_000 is chosen so that the genesis block can specify reward precisely enough to control about a hundredth of a percent APR for rewards that are delivered per-epoch.

Copy link
Contributor

@bennetyee bennetyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #3065 into master will decrease coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
- Coverage   68.31%   67.80%   -0.51%     
==========================================
  Files         372      372              
  Lines       36487    36487              
==========================================
- Hits        24927    24741     -186     
- Misses       8338     8546     +208     
+ Partials     3222     3200      -22     
Impacted Files Coverage Δ
go/staking/api/rewards.go 60.00% <100.00%> (ø)
go/oasis-node/cmd/ias/auth_registry.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-44.12%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/registry/api/grpc.go 28.74% <0.00%> (-11.32%) ⬇️
go/consensus/tendermint/apps/scheduler/query.go 71.05% <0.00%> (-7.90%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 62.92% <0.00%> (-6.75%) ⬇️
go/storage/metrics.go 71.73% <0.00%> (-6.53%) ⬇️
go/staking/api/grpc.go 53.19% <0.00%> (-5.53%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bc6ad...b641b4b. Read the comment docs.

@pro-wh pro-wh merged commit 2c7e12b into master Jun 29, 2020
@pro-wh pro-wh deleted the pro-wh/feature/denom branch June 29, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants