-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
# value is the quantity of tokens to assign. The tokens are whole tokens so | ||
# when they're translated in the staking ledger they will be multiplied by 1e9 | ||
|
||
# TODO: setup mainnet alocations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ravenac95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah Hrmm I’ll have to get this from Anne if things are different. I’ll check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well i think these will be a bit different (if nothing else, i think there will be some amber awards that will be included?). If this repository won't be used for generating the actual genesis (not sure, if it will?), but only test the submitted entities, then this shouldn't matter all that much. In any case this can be updated at a later time.
74ec82d
to
e27fb20
Compare
9c5121f
to
8f750f8
Compare
Weirdly i can assign only a single reviewer and a single assignee (is this some organization setting?). Anyway cc please review this a bit @tjanez @ravenac95 |
This is because the repository is private and thus limited (we have a free account). When you make it public you will be able to access more features. |
.github/workflows/validate-files.yml
Outdated
--chain-id-prefix amber | ||
--genesis-time 2020-06-18T16:00:00 | ||
--chain-id-prefix mainnet | ||
--genesis-time 2020-09-18T16:00:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Afauvre what date are we going to publicly announce for mainnet launch? This doesn't have to be that date but it is currently listed here as 2020/09/18 at 16:00 UTC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh missed this. lets not list this date right now. is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is only used for testing for now anyway, i renamed the chain-id to 'mainnet-testing' and put a date in past, to avoid any confusion of this resembling an actually date
Minus the todos looks pretty good and the tests should work... I know that Warren and I need to update our "test entities" (we had issues accessing either the last dry run) here but we can do that in a different PR. |
In that case i'll remove the test entities as well, and we can use those to test this, before making this public :-) |
For review i suggest manually diffing to master branch of https://github.com/oasisprotocol/amber-network-entities (probably easiest if you addamber-network-entities
&mainnet-entities
as remotes to the same local repo)Actually i'll push a branch from
amber-network-entities
here temporarily and open this PR against it.NOTE: this PR is currently against
amber/master
(which contains master branch state from amber entities repo), for easier reviewing. Before merging I will remove all the amber commits from this branch and merge it into master with a clean history.