Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Initial mainnet entities setup #1

Closed
wants to merge 2 commits into from
Closed

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Aug 12, 2020

For review i suggest manually diffing to master branch of https://github.com/oasisprotocol/amber-network-entities (probably easiest if you add amber-network-entities & mainnet-entities as remotes to the same local repo)

Actually i'll push a branch from amber-network-entities here temporarily and open this PR against it.

NOTE: this PR is currently against amber/master (which contains master branch state from amber entities repo), for easier reviewing. Before merging I will remove all the amber commits from this branch and merge it into master with a clean history.

# value is the quantity of tokens to assign. The tokens are whole tokens so
# when they're translated in the staking ledger they will be multiplied by 1e9

# TODO: setup mainnet alocations.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah Hrmm I’ll have to get this from Anne if things are different. I’ll check!

Copy link
Member Author

@ptrus ptrus Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i think these will be a bit different (if nothing else, i think there will be some amber awards that will be included?). If this repository won't be used for generating the actual genesis (not sure, if it will?), but only test the submitted entities, then this shouldn't matter all that much. In any case this can be updated at a later time.

@ptrus ptrus force-pushed the ptrus/initial branch 2 times, most recently from 74ec82d to e27fb20 Compare August 12, 2020 07:44
@ptrus ptrus requested review from ravenac95 and tjanez and removed request for ravenac95 and tjanez August 12, 2020 07:45
@ptrus ptrus force-pushed the ptrus/initial branch 2 times, most recently from 9c5121f to 8f750f8 Compare August 12, 2020 07:53
@ptrus ptrus changed the base branch from master to amber/master August 12, 2020 07:57
@ptrus
Copy link
Member Author

ptrus commented Aug 12, 2020

Weirdly i can assign only a single reviewer and a single assignee (is this some organization setting?). Anyway cc please review this a bit @tjanez @ravenac95

@kostko
Copy link
Member

kostko commented Aug 12, 2020

Weirdly i can assign only a single reviewer and a single assignee (is this some organization setting?). Anyway cc please review this a bit @tjanez @ravenac95

This is because the repository is private and thus limited (we have a free account). When you make it public you will be able to access more features.

--chain-id-prefix amber
--genesis-time 2020-06-18T16:00:00
--chain-id-prefix mainnet
--genesis-time 2020-09-18T16:00:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Afauvre what date are we going to publicly announce for mainnet launch? This doesn't have to be that date but it is currently listed here as 2020/09/18 at 16:00 UTC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh missed this. lets not list this date right now. is that ok?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is only used for testing for now anyway, i renamed the chain-id to 'mainnet-testing' and put a date in past, to avoid any confusion of this resembling an actually date

@ravenac95
Copy link
Contributor

Minus the todos looks pretty good and the tests should work... I know that Warren and I need to update our "test entities" (we had issues accessing either the last dry run) here but we can do that in a different PR.

@ptrus
Copy link
Member Author

ptrus commented Aug 14, 2020

Minus the todos looks pretty good and the tests should work... I know that Warren and I need to update our "test entities" (we had issues accessing either the last dry run) here but we can do that in a different PR.

In that case i'll remove the test entities as well, and we can use those to test this, before making this public :-)

@ptrus ptrus closed this Aug 14, 2020
@ptrus ptrus mentioned this pull request Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants