Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage #2832

Merged
merged 10 commits into from
Apr 13, 2020
Merged

Improve code coverage #2832

merged 10 commits into from
Apr 13, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 9, 2020

See #1134.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2832 into master will increase coverage by 1.23%.
The diff coverage is 77.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   66.25%   67.49%   +1.23%     
==========================================
  Files         345      344       -1     
  Lines       33269    33071     -198     
==========================================
+ Hits        22044    22321     +277     
+ Misses       8361     7895     -466     
+ Partials     2864     2855       -9     
Impacted Files Coverage Δ
go/common/address.go 72.60% <ø> (+9.93%) ⬆️
go/oasis-node/cmd/root.go 86.48% <ø> (-0.36%) ⬇️
go/storage/mkvs/tree.go 92.85% <ø> (+10.09%) ⬆️
go/oasis-node/cmd/ias/auth_registry.go 69.23% <65.90%> (+69.23%) ⬆️
go/common/cbor/codec.go 77.14% <80.00%> (+12.43%) ⬆️
go/common/args.go 100.00% <100.00%> (ø)
go/common/testing/e2e_coverage.go 100.00% <100.00%> (ø)
go/runtime/client/tests/tester.go 100.00% <100.00%> (ø)
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/roothash/roothash.go 65.54% <0.00%> (-6.00%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f59f4a...48a058a. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/coverage branch 2 times, most recently from f6d1cd8 to 8ffceba Compare April 9, 2020 12:27
@kostko kostko force-pushed the kostko/fix/coverage branch from 8ffceba to 5b5182c Compare April 10, 2020 11:54
@kostko kostko force-pushed the kostko/fix/coverage branch from c340680 to 8c96ff4 Compare April 13, 2020 10:10
@kostko kostko force-pushed the kostko/fix/coverage branch from 8c96ff4 to 4a99809 Compare April 13, 2020 10:25
Previously the IAS proxy could incorrectly panic during shutdown when the
context was cancelled.
@kostko kostko marked this pull request as ready for review April 13, 2020 12:14
@kostko kostko merged commit edb76f1 into master Apr 13, 2020
@kostko kostko deleted the kostko/fix/coverage branch April 13, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants