-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage #2832
Merged
Merged
Improve code coverage #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2832 +/- ##
==========================================
+ Coverage 66.25% 67.49% +1.23%
==========================================
Files 345 344 -1
Lines 33269 33071 -198
==========================================
+ Hits 22044 22321 +277
+ Misses 8361 7895 -466
+ Partials 2864 2855 -9
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/fix/coverage
branch
2 times, most recently
from
April 9, 2020 12:27
f6d1cd8
to
8ffceba
Compare
kostko
force-pushed
the
kostko/fix/coverage
branch
from
April 10, 2020 11:54
8ffceba
to
5b5182c
Compare
kostko
force-pushed
the
kostko/fix/coverage
branch
from
April 13, 2020 10:10
c340680
to
8c96ff4
Compare
kostko
force-pushed
the
kostko/fix/coverage
branch
from
April 13, 2020 10:25
8c96ff4
to
4a99809
Compare
Previously the IAS proxy could incorrectly panic during shutdown when the context was cancelled.
Yawning
reviewed
Apr 13, 2020
Yawning
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1134.