Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKVS fixes and improvements #2691

Merged
merged 5 commits into from
Feb 19, 2020
Merged

MKVS fixes and improvements #2691

merged 5 commits into from
Feb 19, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 18, 2020

Extracted from #2674 for easier review.

Contains a fix for an MKVS iterator bug.

@kostko kostko force-pushed the kostko/feature/mkvs-improvements branch 2 times, most recently from 6ca243e to 115f49f Compare February 18, 2020 17:21
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #2691 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
- Coverage   63.09%   63.03%   -0.07%     
==========================================
  Files         376      377       +1     
  Lines       35325    35440     +115     
==========================================
+ Hits        22289    22339      +50     
- Misses      10236    10289      +53     
- Partials     2800     2812      +12     
Impacted Files Coverage Δ
go/consensus/tendermint/api/api.go 73.58% <0.00%> (-15.10%) ⬇️
go/consensus/api/grpc.go 57.02% <0.00%> (-6.62%) ⬇️
go/runtime/committee/nodes.go 80.64% <0.00%> (-2.16%) ⬇️
go/consensus/tendermint/tendermint.go 66.48% <0.00%> (-1.67%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.70% <0.00%> (-1.38%) ⬇️
go/runtime/transaction/transaction.go 75.90% <0.00%> (-1.21%) ⬇️
go/worker/compute/executor/committee/node.go 60.82% <0.00%> (-1.19%) ⬇️
go/storage/client/client.go 77.31% <0.00%> (-0.85%) ⬇️
go/worker/compute/merge/committee/node.go 75.37% <0.00%> (-0.50%) ⬇️
go/storage/mkvs/urkel/overlay.go 73.52% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a68809...91efcae. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/mkvs-improvements branch 2 times, most recently from b5cf0f9 to 812a510 Compare February 18, 2020 20:38
@kostko kostko added the c:storage Category: storage label Feb 18, 2020
@kostko kostko force-pushed the kostko/feature/mkvs-improvements branch from 812a510 to 91efcae Compare February 19, 2020 14:41
@kostko kostko merged commit 19a39b2 into master Feb 19, 2020
@kostko kostko deleted the kostko/feature/mkvs-improvements branch March 30, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:storage Category: storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants