Roothash processing fees #2504
Merged
Roothash processing fees #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
==========================================
- Coverage 66.97% 66.89% -0.09%
==========================================
Files 328 330 +2
Lines 30263 30498 +235
==========================================
+ Hits 20270 20403 +133
- Misses 7469 7538 +69
- Partials 2524 2557 +33
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/rt-registration
branch
7 times, most recently
from
6f3b705 to
7cd1536
Compare
kostko
force-pushed
the
kostko/feature/rt-registration
branch
6 times, most recently
from
21371cd to
c6acc1d
Compare
kostko
force-pushed
the
kostko/feature/rt-registration
branch
7 times, most recently
from
0727eb7 to
373f63f
Compare
kostko
force-pushed
the
kostko/feature/rt-registration
branch
2 times, most recently
from
52f453c to
ffd9087
Compare
kostko
force-pushed
the
kostko/feature/rt-registration
branch
4 times, most recently
from
fe9724b to
e130bfa
Compare
Yawning
reviewed
Jan 14, 2020
| @@ -122,7 +122,7 @@ func (app *beaconApplication) onBeaconEpochChange(ctx *abci.Context, epoch epoch | |||
| case true: | |||
| // UNSAFE/DEBUG - Deterministic beacon. | |||
| entropyCtx = debugEntropyCtx | |||
| entropy = []byte("If you change this, you will fuck up the byzantine tests!!") | |||
| entropy = []byte("If you change this, you will fuck up the byzantine tests!!!") | |||
There was a problem hiding this comment.
At some point we should probably just add in hacks to the scheduler that just schedules things "correctly" for the byzantine tests.
| ) | ||
| return errors.Wrap(err, "registry: genesis suspended runtime registration failure") | ||
| } | ||
| var rt registry.Runtime |
There was a problem hiding this comment.
Instead of doing this, just make app.registerRuntime return (*registry.Runtime, error)?
Otherwise, the cbor.Unmarshal call failing is a sign that something when absolutely horrifically wrong since the runtime registration does an Unmarshal.
kostko
force-pushed
the
kostko/feature/rt-registration
branch
from
e130bfa to
e28cc5e
Compare
Yawning
approved these changes
Jan 14, 2020
kostko
force-pushed
the
kostko/feature/rt-registration
branch
from
e28cc5e to
a3e3b56
Compare
This avoids the need for passing the message type as an interface{} and
thus reflection. It also cleans up some unnecessary arguments.
This refactors the rather large onCommitteeChanged method so that it is possible to apply runtime state updates in a single pass: - Preparation of new commitment pool structures based on the latest scheduler and registry states is now part of prepareNewCommittees. - Failing to fetch either committees from scheduler state or node info from registry state is now a hard error as it indicates some kind of internal state inconsistency.
Previously the set of orphaned nodes was not cleared when doing rollback which could have resulted in incorrect nodes being marked as orphaned.
Previously a compute worker would start processing requests even if the runtime required a key manager but one wasn't yet available. This caused the processing of confidential runtime transactions to fail.
kostko
force-pushed
the
kostko/feature/rt-registration
branch
from
a3e3b56 to
80cb5dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2406.
TODO
registerRuntime.