Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace epochtime with ticker #1793

Closed
ptrus opened this issue Jun 7, 2019 · 3 comments
Closed

Replace epochtime with ticker #1793

ptrus opened this issue Jun 7, 2019 · 3 comments
Assignees
Labels
c:common Category: common libraries c:registry Category: entity/node/runtime registry service

Comments

@ptrus
Copy link
Member

ptrus commented Jun 7, 2019

Replace epochtime with a ticker-time. The general idea is that ticker will serve as a (configurable) base frequency. Everything currently relying on epochtime.WatchEpochs will be able to be configured as a multiplayer of the base frequency.

This will also enable: #1654
And deprecate: #1762

Details

  • rename epochtime to ticker
  • Extend api to include: WatchTicks(multiplyer uint64) (<-chan api.Ticker, *pubsub.Subscription)
  • everything currently using WatchEpochs should be updated to use the configurable WatchTciks() (with configurable multiplyer)
@ptrus ptrus self-assigned this Jun 7, 2019
@ptrus ptrus added c:common Category: common libraries c:registry Category: entity/node/runtime registry service labels Jun 7, 2019
@ptrus
Copy link
Member Author

ptrus commented Jun 11, 2019

Additional thoughts/plan:

  • remove the notion of epochs completely, instead there'll be compute/txnscheduler/compute/registry/...-intervals
  • since there's no more notion of "global" epoch, we cannot rely on per "epochs" lists, instead the API's between services should be per "block heights" -> this requires Remove non-Tendermint backends #1799 as currently non-tendermint backends don't have notion of heights.

@ptrus
Copy link
Member Author

ptrus commented Jul 1, 2019

Also: fold epochtime under the consensus.backend banner, and give epochtime/tendermint_mock the #1872 treatment

@kostko
Copy link
Member

kostko commented Jul 1, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:common Category: common libraries c:registry Category: entity/node/runtime registry service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants