Merge pull request #3107 from oasisprotocol/tjanez/test-runner-parall…

…el-bug

go/oasis-test-runner/cmd: Sort scenarios for correct parallel execution

.changelog/3104.bugfix.md

@@ -0,0 +1 @@
+go/oasis-test-runner/cmd: Sort scenarios for correct parallel execution

go/oasis-test-runner/cmd/root.go

@@ -305,16 +305,26 @@ func runRoot(cmd *cobra.Command, args []string) error {
 		}
 	}
 
+	// Sort requested scenarios to enable consistent partitioning for parallel
+	// job execution.
+	sort.Slice(toRun, func(i, j int) bool { return toRun[i].Name() < toRun[j].Name() })
+
 	excludeMap := make(map[string]bool)
 	if excludeEnv := os.Getenv("OASIS_EXCLUDE_E2E"); excludeEnv != "" {
 		for _, v := range strings.Split(excludeEnv, ",") {
 			excludeMap[strings.ToLower(v)] = true
 		}
 	}
 
-	// Run the required test scenarios.
+	// Get parallel job execution parameters.
 	parallelJobCount := viper.GetInt(cfgParallelJobCount)
 	parallelJobIndex := viper.GetInt(cfgParallelJobIndex)
+	if parallelJobIndex < 0 || parallelJobIndex >= parallelJobCount {
+		return fmt.Errorf(
+			"root: invalid value of %s flag: %d (should be in range [0, %d))",
+			cfgParallelJobIndex, parallelJobIndex, parallelJobCount,
+		)
+	}
 
 	// Parse test parameters passed by CLI.
 	var toRunExploded map[string][]scenario.Scenario