Merge pull request #2908 from oasislabs/pro-wh/feature/rank

go stats: give ties the same rank
oasisprotocol · May 29, 2020 · bfce631 · bfce631
1 parent 08a6429
commit bfce631
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changelog/2908.feature.md b/.changelog/2908.feature.md
@@ -0,0 +1,4 @@
+go/extra/stats: Give ties the same rank
+
+Previously records tied by availability score would get different
+ranks, which was wrong.
diff --git a/go/extra/stats/cmd/stats.go b/go/extra/stats/cmd/stats.go
@@ -113,8 +113,14 @@ func (s stats) printEntityAvailability(topN int) {
 	// Print results.
 	written, _ := fmt.Printf("|%-5s|%-64s|%-6s|%13s|%10s|%14s|%9s|%18s|\n", "Rank", "Entity ID", "Nodes", "Had validator", "Signatures", "Times selected", "Proposals", "Availability score")
 	fmt.Println(strings.Repeat("-", written-1))
+	rank := 0
+	tieScore := int64(0)
 	for idx, r := range res {
-		fmt.Printf("|%-5d|%-64s|%6d|%13d|%10d|%14d|%9d|%18d|\n", idx+1, r.entityID, r.nodes, r.elections, r.signatures, r.selections, r.proposals, r.availabilityScore)
+		if idx == 0 || r.availabilityScore != tieScore {
+			rank = idx + 1
+			tieScore = r.availabilityScore
+		}
+		fmt.Printf("|%-5d|%-64s|%6d|%13d|%10d|%14d|%9d|%18d|\n", rank, r.entityID, r.nodes, r.elections, r.signatures, r.selections, r.proposals, r.availabilityScore)
 	}
 }