Merge pull request #3230 from oasisprotocol/tjanez/cli-dont-print-err…

…ors-twice

go: Fix CLI tools to not print error messages twice

.changelog/3230.bugfix.md

@@ -0,0 +1 @@
+go: Fix CLI tools to not print error messages twice

go/extra/stats/cmd/root.go

@@ -3,6 +3,7 @@ package cmd
 
 import (
 	"fmt"
+	"os"
 
 	"github.com/spf13/cobra"
 	flag "github.com/spf13/pflag"
@@ -38,7 +39,7 @@ func Execute() {
 	}
 
 	if err := rootCmd.Execute(); err != nil {
-		common.EarlyLogAndExit(err)
+		os.Exit(1)
 	}
 }
 

go/oasis-net-runner/cmd/root.go

@@ -57,7 +57,7 @@ func RootCmd() *cobra.Command {
 // Execute spawns the main entry point after handing the config file.
 func Execute() {
 	if err := rootCmd.Execute(); err != nil {
-		common.EarlyLogAndExit(err)
+		os.Exit(1)
 	}
 }
 

go/oasis-node/cmd/root.go

@@ -2,6 +2,7 @@
 package cmd
 
 import (
+	"os"
 	"syscall"
 
 	"github.com/spf13/cobra"
@@ -41,7 +42,7 @@ func Execute() {
 	syscall.Umask(0o077)
 
 	if err := rootCmd.Execute(); err != nil {
-		cmdCommon.EarlyLogAndExit(err)
+		os.Exit(1)
 	}
 }
 

go/oasis-remote-signer/cmd/root.go

@@ -62,7 +62,7 @@ var (
 // Execute spawns the main entry point after handling the config file.
 func Execute() {
 	if err := rootCmd.Execute(); err != nil {
-		cmdCommon.EarlyLogAndExit(err)
+		os.Exit(1)
 	}
 }