go/oasis-node/cmd/common/metrics: Fix label escaping

.changelog/3678.internal.md

@@ -0,0 +1 @@
+go/oasis-node/cmd/common/metrics: Fix label escaping

go/oasis-node/cmd/common/metrics/metrics.go

@@ -272,7 +272,14 @@ func Enabled() bool {
 
 // EscapeLabelCharacters replaces invalid prometheus label name characters with "_".
 func EscapeLabelCharacters(l string) string {
-	return strings.Replace(l, ".", "_", -1)
+	return strings.Map(func(r rune) rune {
+		switch r {
+		case '.', '-', ' ':
+			return '_'
+		default:
+			return r
+		}
+	}, l)
 }
 
 // GetDefaultPushLabels generates standard Prometheus push labels based on test current test instance info.

go/oasis-node/cmd/common/metrics/metrics_test.go

@@ -0,0 +1,23 @@
+package metrics
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func TestEscapeLabelCharacters(t *testing.T) {
+	require := require.New(t)
+
+	for _, tc := range []struct {
+		input    string
+		expected string
+	}{
+		{"hello", "hello"},
+		{"hello world", "hello_world"},
+		{"one-two_three", "one_two_three"},
+		{"a-b c.d.e.f--g", "a_b_c_d_e_f__g"},
+	} {
+		require.EqualValues(tc.expected, EscapeLabelCharacters(tc.input))
+	}
+}