ci: Remove push path filters for dockerfile build action

oasisprotocol · Jun 10, 2020 · 45d4fdd · 45d4fdd
1 parent deef73c
commit 45d4fdd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changelog/2997.internal.md b/.changelog/2997.internal.md
@@ -0,0 +1 @@
+ci: Remove push path filters for dockerfile build action
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -3,13 +3,17 @@ name: docker
 
 # Trigger the workflow when:
 on:
-  # A push occurs to one of the matched branches and at least one modified file matches the configured paths.
+  # A push occurs to one of the matched branches.
   push:
+    # XXX: ideally on master branches we would build the image only if there are changes in the
+    # 'docker/' directory (as we do in pull_requests). However, this doesn't work when pushing a new
+    # 'stable/*' branch - the build on a new branch does not trigger unless there are changes
+    # compared to master on the filtered path.
+    # If this is ever fixed, or per branch filters are possible, bring back the path filter to only
+    # build the image when there are changes within 'docker/' directory.
     branches:
       - master
       - stable/*
-    paths:
-      - docker/**
   # Or when a pull request event occurs for a pull request against one of the matched branches and at least
   # one modified file matches the configured paths.
   #
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		ci: Remove push path filters for dockerfile build action