Disallow v0 entity/node/runtime descriptors

.changelog/2992.breaking.md

@@ -0,0 +1 @@
+Disallow v0 entity/node/runtime descriptors

go/common/entity/entity.go

@@ -34,7 +34,7 @@ const (
 	LatestEntityDescriptorVersion = 1
 
 	// Minimum and maximum descriptor versions that are allowed.
-	minEntityDescriptorVersion = 0
+	minEntityDescriptorVersion = 1
 	maxEntityDescriptorVersion = LatestEntityDescriptorVersion
 )
 
@@ -52,11 +52,11 @@ type Entity struct { // nolint: maligned
 	// Nodes is the vector of node identity keys owned by this entity, that
 	// will sign the descriptor with the node signing key rather than the
 	// entity signing key.
-	Nodes []signature.PublicKey `json:"nodes"`
+	Nodes []signature.PublicKey `json:"nodes,omitempty"`
 
 	// AllowEntitySignedNodes is true iff nodes belonging to this entity
 	// may be signed with the entity signing key.
-	AllowEntitySignedNodes bool `json:"allow_entity_signed_nodes"`
+	AllowEntitySignedNodes bool `json:"allow_entity_signed_nodes,omitempty"`
 }
 
 // ValidateBasic performs basic descriptor validity checks.

go/common/node/node.go

@@ -39,7 +39,7 @@ const (
 	LatestNodeDescriptorVersion = 1
 
 	// Minimum and maximum descriptor versions that are allowed.
-	minNodeDescriptorVersion = 0
+	minNodeDescriptorVersion = 1
 	maxNodeDescriptorVersion = LatestNodeDescriptorVersion
 )
 

go/registry/api/runtime.go

@@ -177,7 +177,7 @@ const (
 	LatestRuntimeDescriptorVersion = 1
 
 	// Minimum and maximum descriptor versions that are allowed.
-	minRuntimeDescriptorVersion = 0
+	minRuntimeDescriptorVersion = 1
 	maxRuntimeDescriptorVersion = LatestRuntimeDescriptorVersion
 )
 

go/upgrade/migrations/dummy.go

@@ -30,6 +30,7 @@ var (
 
 func init() {
 	entitySigner = memory.NewTestSigner(testSigningSeed)
+	TestEntity.DescriptorVersion = entity.LatestEntityDescriptorVersion
 	TestEntity.ID = entitySigner.Public()
 }