go/tendermint/keymanager: error Status() if keymanager doesn't exist

oasisprotocol · Jan 31, 2020 · 06d2b27 · 06d2b27
1 parent b3ee039
commit 06d2b27
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/.changelog/2628.bugfix.md b/.changelog/2628.bugfix.md
@@ -0,0 +1,4 @@
+go/tendermint/keymanager: error in Status() if keymanager doesn't exist
+
+This fixes panics in the key-manager client if keymanager for the specific
+runtime doesn't exist.
diff --git a/go/consensus/tendermint/apps/keymanager/state/state.go b/go/consensus/tendermint/apps/keymanager/state/state.go
@@ -60,7 +60,7 @@ func (st *ImmutableState) getStatusesRaw() ([][]byte, error) {
 func (st *ImmutableState) Status(id common.Namespace) (*api.Status, error) {
 	_, raw := st.Snapshot.Get(statusKeyFmt.Encode(&id))
 	if raw == nil {
-		return nil, nil
+		return nil, api.ErrNoSuchKeyManager
 	}
 
 	var status api.Status