Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: omitempty nodeapi.Event alternates #763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

storage: omitempty nodeapi.Event alternates #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions storage/oasis/nodeapi/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,29 +131,29 @@ type Event struct {
// Called "Kind" in oasis-core but "Type" in Nexus APIs and DBs.
Type apiTypes.ConsensusEventType

StakingTransfer *TransferEvent
StakingBurn *BurnEvent
StakingAddEscrow *AddEscrowEvent
StakingTakeEscrow *TakeEscrowEvent
StakingEscrowDebondingStart *DebondingStartEscrowEvent
StakingReclaimEscrow *ReclaimEscrowEvent
StakingDebondingStart *DebondingStartEscrowEvent // Available starting in Damask.
StakingAllowanceChange *AllowanceChangeEvent

RegistryRuntimeStarted *RuntimeStartedEvent
RegistryRuntimeSuspended *RuntimeSuspendedEvent // Available starting with Eden.
RegistryEntity *EntityEvent
RegistryNode *NodeEvent
RegistryNodeUnfrozen *NodeUnfrozenEvent

RoothashMisc *RoothashEvent
RoothashExecutorCommitted *ExecutorCommittedEvent
RoothashMessage *MessageEvent // Available only in Cobalt.

GovernanceProposalSubmitted *ProposalSubmittedEvent
GovernanceProposalExecuted *ProposalExecutedEvent
GovernanceProposalFinalized *ProposalFinalizedEvent
GovernanceVote *VoteEvent
StakingTransfer *TransferEvent `json:",omitempty"`
Copy link
Member

@ptrus ptrus Nov 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we used to have the omitempty annotations here and removed them in 02df003 (by mistake?).

Should we also add them back in other places that were removed (e.g. VRFPubKey field)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrew7234 how did those json annotations come up in the api tests PR?

StakingBurn *BurnEvent `json:",omitempty"`
StakingAddEscrow *AddEscrowEvent `json:",omitempty"`
StakingTakeEscrow *TakeEscrowEvent `json:",omitempty"`
StakingEscrowDebondingStart *DebondingStartEscrowEvent `json:",omitempty"`
StakingReclaimEscrow *ReclaimEscrowEvent `json:",omitempty"`
StakingDebondingStart *DebondingStartEscrowEvent `json:",omitempty"` // Available starting in Damask.
StakingAllowanceChange *AllowanceChangeEvent `json:",omitempty"`

RegistryRuntimeStarted *RuntimeStartedEvent `json:",omitempty"`
RegistryRuntimeSuspended *RuntimeSuspendedEvent `json:",omitempty"` // Available starting with Eden.
RegistryEntity *EntityEvent `json:",omitempty"`
RegistryNode *NodeEvent `json:",omitempty"`
RegistryNodeUnfrozen *NodeUnfrozenEvent `json:",omitempty"`

RoothashMisc *RoothashEvent `json:",omitempty"`
RoothashExecutorCommitted *ExecutorCommittedEvent `json:",omitempty"`
RoothashMessage *MessageEvent `json:",omitempty"` // Available only in Cobalt.

GovernanceProposalSubmitted *ProposalSubmittedEvent `json:",omitempty"`
GovernanceProposalExecuted *ProposalExecutedEvent `json:",omitempty"`
GovernanceProposalFinalized *ProposalFinalizedEvent `json:",omitempty"`
GovernanceVote *VoteEvent `json:",omitempty"`
}

// .................... Staking ....................
Expand Down
Loading