api/consensus/validators: Expose validator signed blocks info #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/validator-signed-blocks
branch
3 times, most recently
from
55f9939 to
9294586
Compare
ptrus
changed the title
ptrus
force-pushed
the
ptrus/feature/validator-signed-blocks
branch
7 times, most recently
from
3cebf3d to
34b6a16
Compare
Andrew7234
reviewed
Oct 8, 2024
storage/client/queries/queries.go
Outdated
Comment on lines
323
to
333
| ValidatorLast100BlocksSigned = ` | ||
| SELECT | ||
| height, | ||
| COALESCE($1 = ANY(signer_entity_ids), FALSE) | ||
| FROM ( | ||
| SELECT height, signer_entity_ids | ||
| FROM chain.blocks | ||
| ORDER BY height DESC | ||
| LIMIT 100 | ||
| ) AS subquery | ||
| ORDER BY height ASC` |
There was a problem hiding this comment.
Is there a use case to sort by height ASC? I think the explorer is displaying the blocks in desc order so maybe we can just leave it as height DESC, and it simplifies the query too.
There was a problem hiding this comment.
Will ask forntend if they care about the order here.
There was a problem hiding this comment.
Updated to return in DESC order and simplified the query.
ptrus
force-pushed
the
ptrus/feature/validator-signed-blocks
branch
from
34b6a16 to
41f7ea4
Compare
ptrus
force-pushed
the
ptrus/feature/validator-signed-blocks
branch
from
41f7ea4 to
1e7c373
Compare
Andrew7234
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether it is a validator prop or separated endpoint is up to backend. Oasis Scan returns an array of { block: boolean height: number }
https://www.oasisscan.com/mainnet/validator/stats?address=oasis1qqekv2ymgzmd8j2s2u7g0hhc7e77e654kvwqtjwm
In UI we want to showLast 100 blocks