Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrew7234/validator staking api #732

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Andrew7234
Copy link
Collaborator

@Andrew7234 Andrew7234 commented Jul 24, 2024

api: Add %24hr escrow change for validators

Adds the corresponding api for #728.

Also cleans up some inconsistencies in the spec.

@Andrew7234 Andrew7234 requested review from pro-wh and ptrus as code owners July 24, 2024 21:57
@Andrew7234 Andrew7234 force-pushed the andrew7234/validator-staking-history branch from f6c69cc to d0860ec Compare July 24, 2024 21:58
api/spec/v1.yaml Outdated
format: uint64
description: The number of accounts that have delegated token to this account.

EscrowHistory:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was also considering naming this ValidatorHistory and ValidatorHistoryPoint below; open to suggestions

@@ -1933,6 +1970,61 @@ components:
self_delegation_shares:
allOf: [$ref: '#/components/schemas/TextBigInt']
description: The shares of tokens this validator has delegated to itself, and are NOT in the process of debonding.
active_balance_24:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This attempts to find the balance 24 epochs ago, which isn't exactly 24 hours but it's accurate enough. Also open to field name suggestions here.

@Andrew7234 Andrew7234 force-pushed the andrew7234/validator-staking-history branch 4 times, most recently from db66469 to 8edbb44 Compare July 29, 2024 20:43
Base automatically changed from andrew7234/validator-staking-history to main July 29, 2024 21:44
@Andrew7234 Andrew7234 force-pushed the andrew7234/validator-staking-api branch from aefcf26 to 2ff8c9f Compare July 29, 2024 21:46
@Andrew7234 Andrew7234 force-pushed the andrew7234/validator-staking-api branch from 7ebcc32 to 27cc423 Compare July 30, 2024 17:43
changelog

update eden e2e tests

rename to validatorHistory
@Andrew7234 Andrew7234 force-pushed the andrew7234/validator-staking-api branch from b94e2a3 to 00f7267 Compare July 31, 2024 23:08
@Andrew7234 Andrew7234 merged commit 13805ba into main Aug 1, 2024
16 checks passed
@Andrew7234 Andrew7234 deleted the andrew7234/validator-staking-api branch August 1, 2024 00:28
@csillag csillag mentioned this pull request Dec 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants