storage/client: don't crash on 0 delegated shares #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/dont-crash-on-0-shares
branch
from
43ae792 to
769f149
Compare
ptrus
force-pushed
the
ptrus/fix/dont-crash-on-0-shares
branch
from
769f149 to
1b4f32c
Compare
pro-wh
approved these changes
Jul 1, 2024
| @@ -844,10 +844,19 @@ func (c *StorageClient) Account(ctx context.Context, address staking.Address) (* | |||
| } | |||
|
|
|||
| // Computes shares worth given total shares and total balance. | |||
| func amountFromShares(shares common.BigInt, totalShares common.BigInt, totalBalance common.BigInt) common.BigInt { | |||
| func amountFromShares(shares common.BigInt, totalShares common.BigInt, totalBalance common.BigInt) (common.BigInt, error) { | |||
| if shares.IsZero() { | |||
There was a problem hiding this comment.
ℹ️ db has some leftover cases where shares=0 and totalShares=0. this prevents us from complaining in that case
(is that right? in my understanding from the PR description and related PRs)
There was a problem hiding this comment.
is that right? in my understanding from the PR description and related PRs
Yes, although I'm not 100% sure if shares=0 and totalShares=0 will still exist after all PRs are deployed and we do a reindex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bugs, we can end up with invalid delegations in DB with 0 shares.
I believe most of these cases are fixed in: #713 #711 #712
but still, don't panic since this is part of the public API; instead, log an error and report 0 shares.