storage: add chain.evm_tokens token_name index #466
Conversation
| @@ -309,6 +309,10 @@ func (c *Client) listIndexerMaterializedViews(ctx context.Context) ([]string, er | |||
|
|
|||
| // Wipe removes all contents of the database. | |||
| func (c *Client) Wipe(ctx context.Context) error { | |||
| if _, err := c.pool.Exec(ctx, "DROP EXTENSION IF EXISTS pg_trgm CASCADE;"); err != nil { | |||
There was a problem hiding this comment.
this works out okay when it's at the beginning, because this way dropping the extension with cascade cleans up its types and functions
| @@ -322,6 +326,7 @@ func (c *Client) Wipe(ctx context.Context) error { | |||
|
|
|||
| // List, then drop all custom types. | |||
| // Query from https://stackoverflow.com/questions/3660787/how-to-list-custom-types-using-postgres-information-schema | |||
| // TODO: Don't delete extensions' types. | |||
There was a problem hiding this comment.
Is this really a TODO, now that we're dropping the extension?
There was a problem hiding this comment.
we can switch course to dropping all extensions (except for some)
There was a problem hiding this comment.
Oh I see, so IIUC it's a TODO in the sense that if we added another extension, and that extension defined a custom type, and we chose not to use DROP EXTENSION IF EXISTS on it, we'd have to amend this code here so that it doesn't delete the extension's types.
In that hypothetical world, the same goes for other objects I guess? I don't know enough about postgres extensions but I imagine they can introduce functions and tables and whatnot.
Maybe this line can be something a little milder? Like NOTE: If you introduce postgres extensions with their own custom types, this will try to delete those types too.
I don't see it as a realistic TODO, i.e. I don't expect us to ever need to work on it in a principled way.
pro-wh
force-pushed
the
pro-wh/feature/wipe
branch
from
ce16ddb to
5f5bf36
Compare
pro-wh
force-pushed
the
pro-wh/feature/trgm
branch
from
3e93308 to
0976f19
Compare
pro-wh
force-pushed
the
pro-wh/feature/wipe
branch
from
5f5bf36 to
a665fa3
Compare
pro-wh
force-pushed
the
pro-wh/feature/trgm
branch
from
0976f19 to
9b6a2d6
Compare
pro-wh
force-pushed
the
pro-wh/feature/wipe
branch
from
a665fa3 to
34fb65d
Compare
pro-wh
force-pushed
the
pro-wh/feature/trgm
branch
from
9b6a2d6 to
2394356
Compare
|
Is this still relevant? |
|
I think we put it off until the search got slower |
There was a problem hiding this comment.
Not sure how this fell through the cracks unapproved for so long. Thank you, LGTM!
Remaining request: I did find the TODO in the code very confusing again (I was reading this with fresh eyes now, a year after the first review), and would strongly prefer to see it reworded the way I suggested in the comment thread, or similarly.
from #460
This speeds up searching tokens by name. For simplicity, we're not merging this for now (2024-06) until search proves problematically slow.