Add missing data to Consensus tx list #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/consensusTxList
branch
2 times, most recently
from
fb98cf9 to
3390cbb
Compare
buberdds
force-pushed
the
mz/consensusTxList
branch
from
3390cbb to
b857bd8
Compare
buberdds
commented
Jun 27, 2024
| > | ||
|
|
||
| const tableRows = transactions?.map(transaction => { | ||
| const targetAddress = transaction.body.to || transaction.body.account |
There was a problem hiding this comment.
Transactions consensus and runtime APIs are not consistent:
runtime has props
amount?: string;
to?: Address;
where here we use body. not sure this should be unified in Nexus. Current API might work fine with new design where we will have to render different body props depends on a tx type.
There was a problem hiding this comment.
I would say it would be nice to unify, but not high priority. Let's make it work on our side, and BE can resolve it, once they find the time.
lubej
approved these changes
Jun 27, 2024
lubej
reviewed
Jun 27, 2024
| const tableRows = transactions?.map(transaction => { | ||
| const targetAddress = transaction.body.to || transaction.body.account | ||
| return { | ||
| key: `${transaction.hash}${transaction.index}`, |
There was a problem hiding this comment.
No need for ${transaction.index} I think. Tx hash should be unique enough, unless there is a case, where it's missing or duplicated.
There was a problem hiding this comment.
it was needed in the past #1412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide data for transactions list
toandvaluecolumns.side note: these columns will be merged into
Detailscolumn when designs are ready