Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus: add debonding delegations to Staking card #1461

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Jun 27, 2024

  • still showing validator address instead a name. This will be resolved in the future when validator_media object will be added, or by named accounts
  • debonding list can show children with the same key warning temporary. Validator address + epoch will be unique in debonding delegations once bugfix is deployed on Nexus side
  • filter buttons use styles from other Consensus card not from mockups (not sure why they are different)
  • last commit includes changes provided by Tadej

Copy link

github-actions bot commented Jun 27, 2024

Deployed to Cloudflare Pages

Latest commit: 6949bb2645b89f3c9d3f9d2b64b39f777c64a99f
Status:✅ Deploy successful!
Preview URL: https://aa30668f.oasis-explorer.pages.dev

@buberdds buberdds changed the title Staking card alternative UX Consensus: add debonding delegations to Staking card Jun 27, 2024
@buberdds buberdds marked this pull request as ready for review June 27, 2024 15:07
@buberdds
Copy link
Contributor Author

bump

src/app/components/Delegations/index.tsx Outdated Show resolved Hide resolved
src/app/components/FilterButtons/index.tsx Outdated Show resolved Hide resolved
@buberdds
Copy link
Contributor Author

will wait for an updated empty state message

@buberdds
Copy link
Contributor Author

will merge as is and update message in a following PR as we will change layout slightly

@buberdds buberdds merged commit 069be84 into master Jul 17, 2024
8 checks passed
@buberdds buberdds deleted the mz/staking-alt branch July 17, 2024 15:24
Comment on lines +118 to +119
if (column.hide) {
return null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: if first column is hidden then stickyColumn doesn't work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove stickyColumn it is not used anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants