-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mobile search issues #1411
Fix mobile search issues #1411
Conversation
Deployed to Cloudflare Pages
|
Should we just remove the search in footer on HomePage for mobile? I don't see the point, because you have the search on the top of the page. |
I have asked the same question to Don, but an answer was to fix z-index. I will validate this one more time with him. |
cc @donouwens |
The reason we have got the search in the footer is that inner pages, like block detail or account pages, often get very long. This way the user has an option to access search from the bottom of the page as well. A sticky navigation was considered but deemed to take up too much screen estate. |
Yes, makes sense on other pages. But not on home page, where the page's height isn't large, and you can almost see both search bars at the same time. |
Agreed, lets remove it from the homepage |
0b94582
to
f68eaf5
Compare
When opening the detailed popup view on mobile the search button occurs in front of it. This should not be the case, it should be hidden behind the poup.
Fixes #1403
current master: