Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile search issues #1411

Merged
merged 3 commits into from
May 17, 2024
Merged

Fix mobile search issues #1411

merged 3 commits into from
May 17, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented May 14, 2024

When opening the detailed popup view on mobile the search button occurs in front of it. This should not be the case, it should be hidden behind the poup.

Fixes #1403

current master:

Screenshot from 2024-05-14 09-13-15
Screenshot from 2024-05-14 09-12-45

Copy link

github-actions bot commented May 14, 2024

Deployed to Cloudflare Pages

Latest commit: 3c176e7c9b390a35c14a2af1f515907450dc1e78
Status:✅ Deploy successful!
Preview URL: https://ff379ff0.oasis-explorer.pages.dev

@lubej
Copy link
Collaborator

lubej commented May 14, 2024

Should we just remove the search in footer on HomePage for mobile? I don't see the point, because you have the search on the top of the page.

@buberdds
Copy link
Contributor Author

I have asked the same question to Don, but an answer was to fix z-index. I will validate this one more time with him.

@buberdds
Copy link
Contributor Author

cc @donouwens

@donouwens
Copy link
Collaborator

The reason we have got the search in the footer is that inner pages, like block detail or account pages, often get very long. This way the user has an option to access search from the bottom of the page as well. A sticky navigation was considered but deemed to take up too much screen estate.

@lubej
Copy link
Collaborator

lubej commented May 14, 2024

The reason we have got the search in the footer is that inner pages, like block detail or account pages, often get very long. This way the user has an option to access search from the bottom of the page as well. A sticky navigation was considered but deemed to take up too much screen estate.

Yes, makes sense on other pages. But not on home page, where the page's height isn't large, and you can almost see both search bars at the same time.

@donouwens
Copy link
Collaborator

The reason we have got the search in the footer is that inner pages, like block detail or account pages, often get very long. This way the user has an option to access search from the bottom of the page as well. A sticky navigation was considered but deemed to take up too much screen estate.

Yes, makes sense on other pages. But not on home page, where the page's height isn't large, and you can almost see both search bars at the same time.

Agreed, lets remove it from the homepage

@buberdds buberdds force-pushed the mz/mobileSearch branch 4 times, most recently from 0b94582 to f68eaf5 Compare May 16, 2024 15:08
src/app/components/Search/index.tsx Show resolved Hide resolved
@buberdds buberdds merged commit 3fcf83e into master May 17, 2024
8 checks passed
@buberdds buberdds deleted the mz/mobileSearch branch May 17, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Homepage search in mobile footer
3 participants