Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named accounts #1398

Merged
merged 4 commits into from
May 22, 2024
Merged

Add named accounts #1398

merged 4 commits into from
May 22, 2024

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Apr 30, 2024

  • Load metadata about Oasis accounts (available via Nexus).
  • Load metadata about Pontus-X accounts
  • Displaying the names
  • Support searching for the names.

Some accounts to test with are listed here.

Copy link

github-actions bot commented Apr 30, 2024

Deployed to Cloudflare Pages

Latest commit: a59aae37d64c1b208c62f85fc3f5066a7d2e0be9
Status:✅ Deploy successful!
Preview URL: https://03dd3ce0.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch from c91d3ec to 60a3e16 Compare May 6, 2024 14:20
@csillag csillag changed the title [W.I.P.] Add named accounts on Oasis Consensus, Emerald, Sapphire Add named accounts on Oasis Consensus, Emerald, Sapphire May 6, 2024
@csillag csillag changed the title Add named accounts on Oasis Consensus, Emerald, Sapphire Add named accounts on Oasis Consensus, Emerald, Sapphire and Pontus-X May 7, 2024
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch from 60a3e16 to d339653 Compare May 7, 2024 13:34
@csillag csillag changed the title Add named accounts on Oasis Consensus, Emerald, Sapphire and Pontus-X Add named accounts May 7, 2024
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch 2 times, most recently from 5f7cfee to a7b311c Compare May 7, 2024 13:36
@csillag csillag marked this pull request as ready for review May 7, 2024 13:37
@csillag csillag requested review from lukaw3d, buberdds and lubej as code owners May 7, 2024 13:37
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch from a7b311c to bd90206 Compare May 9, 2024 05:04
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch 3 times, most recently from b3b16b7 to 97533b7 Compare May 10, 2024 15:41
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch 10 times, most recently from d46375e to c14df63 Compare May 16, 2024 10:50
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch 11 times, most recently from cd8ca3d to 4186bd7 Compare May 21, 2024 15:06
- Load the Pontus-X account names
- Load metadata for Oasis Consensus, Emerald and Sapphire
- Support displaying account names
- Support searching for named accounts by name
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch from 4186bd7 to 5d6970c Compare May 21, 2024 15:27
src/oasis-nexus/api.ts Outdated Show resolved Hide resolved
src/oasis-nexus/api.ts Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/named-accounts-on-oasis branch from 08356dd to 7ceb3c1 Compare May 21, 2024 23:25
@csillag csillag requested a review from lukaw3d May 21, 2024 23:55
csillag added 2 commits May 22, 2024 07:32
Up to now, only the searchTerm was passed on;
now it gets the whole searchParams.

This will make it possible to make more intelligent decisions
about redirections.
When redirecting to an account from search results,
only add the q=whatever query parameter to the end of the URL
if the match was based on a name fragment, and not an address.
@csillag csillag merged commit 728cf80 into master May 22, 2024
8 checks passed
@csillag csillag deleted the csillag/named-accounts-on-oasis branch May 22, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants