Tune links and hashes #1290
Closed
Tune links and hashes #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/tune-links-and-hashes
branch
from
2238690 to
603bd36
Compare
csillag
force-pushed
the
csillag/tune-links-and-hashes
branch
2 times, most recently
from
d5cb70e to
20fdc32
Compare
|
Thanks @csillag I was suggesting to keep the truncate for the addresses in a more standardized way ("0x1234...abcdef"), but this works better IMO. We provide more clarity this way. Just to clarify two things:
|
|
Works with Chrome, but not with FF. Lemme fix that... |
csillag
force-pushed
the
csillag/tune-links-and-hashes
branch
4 times, most recently
from
506dc8a to
9efcad3
Compare
It was not. Now fixed. Firefox:
Chrome:
For account address, no, not before we bring in named accounts in another PR. |
lukaw3d
reviewed
Feb 23, 2024
csillag
force-pushed
the
csillag/tune-links-and-hashes
branch
from
9efcad3 to
4d838d1
Compare
With this, we can adaptively truncate text based on the available space. When truncated, we can display the full version in a tooltip.
csillag
force-pushed
the
csillag/tune-links-and-hashes
branch
from
4d838d1 to
528b5fe
Compare
|
This branch has too many merge conflicts now. I have rebased the code (on the Pontus-X branch), and extracted the relevant parts again into #1396. Closing this as obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@donouwens wrote:
Up to now, on mobile, we were always truncating hashes to a fixed length (the same as in tables).
With this change, we can now display them adaptively, that is, taking up all the space that is available.
A similar change has also been implemented for block hash links and other similar things.