Add support for hiding all fiat values #1281
Conversation
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/support-hiding-all-fiat
branch
from
f4e5697 to
591b37e
Compare
csillag
force-pushed
the
csillag/support-hiding-all-fiat
branch
2 times, most recently
from
c843880 to
d7f9ba5
Compare
csillag
force-pushed
the
csillag/support-hiding-all-fiat
branch
from
d7f9ba5 to
cf22b94
Compare
csillag
force-pushed
the
csillag/support-hiding-all-fiat
branch
from
cf22b94 to
a40da2a
Compare
| @@ -1,4 +1,4 @@ | |||
| const validProtocols = ['http:', 'https:', 'ftp:', 'ipfs:', 'data:'] | |||
| const validProtocols = ['http:', 'https:', 'ftp:', 'ipfs:', 'data:', 'mailto:'] | |||
There was a problem hiding this comment.
This is dangerous oasisprotocol/wallet#228
There was a problem hiding this comment.
Right, but to frame this properly, currently the only place we are using mailto links are the faucet links, which are hardwired in the code.
Maybe we should add this as an exception for the faucet link only, and not in the general frunction?
There was a problem hiding this comment.
Right, but to frame this properly, currently the only place we are using mailto links are the faucet links, which are hardwired in the code.
no, it was ensuring safety of validator logos and NFT links too
There was a problem hiding this comment.
Maybe we should add this as an exception for the faucet link only, and not in the general frunction?
sure, we can consider all our external links as safe
| @@ -53,7 +53,7 @@ export const ParaTimeSnapshot: FC<{ scope: SearchScope }> = ({ scope }) => { | |||
| <Nodes scope={scope} /> | |||
| </StyledGrid> | |||
| <StyledGrid item xs={22} md={5}> | |||
| {!mainToken.free && <TokenPriceCard token={mainToken} />} | |||
| {showFiatValues && !mainToken.free && <TokenPriceCard token={mainToken} />} | |||
There was a problem hiding this comment.
what non-free token are we hiding now?
There was a problem hiding this comment.
The Pontus-X guys don't want to see any fiat values anywhere in their version, not even the price card. So, in their deployment, showFiatValue will be set to false via .env, and so the token price card (for EUROe) will be hidden.
There was a problem hiding this comment.
In our version, including the current master branch, on the PontusX paratime dashboard, we can see the current price of EUROe.
No description provided.