Consensus account details cards #1261
Conversation
buberdds
commented
Feb 15, 2024
•
buberdds
commented
- Balance distribution card
- Staking card
buberdds
force-pushed
the
mz/consensusAccCards
branch
3 times, most recently
from
aa44ca9 to
d558a38
Compare
buberdds
force-pushed
the
mz/consensusAcc
branch
from
96f2db6 to
fe3c0f3
Compare
buberdds
force-pushed
the
mz/consensusAccCards
branch
from
cf063df to
9c5edb1
Compare
Deployed to Cloudflare Pages
|
buberdds
force-pushed
the
mz/consensusAccCards
branch
3 times, most recently
from
ccd341f to
f0a9006
Compare
buberdds
force-pushed
the
mz/consensusAccCards
branch
2 times, most recently
from
87243aa to
cdd39b9
Compare
| delegations: data.delegations.map(delegation => { | ||
| return { | ||
| ...delegation, | ||
| shares: fromBaseUnits(delegation.shares, consensusDecimals), |
There was a problem hiding this comment.
Shares don't have decimals like this. I don't know if we want to convert them and use "gigashares" throughout the app
There was a problem hiding this comment.
For now I will merge as is to avoid conflicts in PR and will address this in a next PR if needed.
There was a problem hiding this comment.
Notes from discussion:
Out of
- 213456546455 shares
- 213.456546455 gigashares
- 213.45... B shares
- 213B shares
"213B shares" is probably nicest
We could reuse the code from token supply display https://explorer.dev.oasis.io/mainnet/sapphire/token ; decimals are not very important
There was a problem hiding this comment.
Can you verify this in #1310 please?
sample acc: https://0a9444e9.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qqnk4au603zs94k0d0n7c0hkx8t4p6r87s60axru
sample validator (with hardcoded GoStaking entity) https://0a9444e9.oasis-explorer.pages.dev/mainnet/consensus/validators/oasis1qpqz2ut6a6prfcjm64xnpnjhsnqny6jqfyav829v/delegators#delegators
buberdds
force-pushed
the
mz/consensusAccCards
branch
from
4edb01f to
cac4db8
Compare
