More white-labeling: support for replacing icons and thumbnail #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/more-white-labeling
branch
2 times, most recently
from
2a8de48 to
46d0d94
Compare
lubej
approved these changes
Feb 14, 2024
Now web manifest, og:image and favicon can also be configured from .env Also, add _META_ to the name of some .env entries.
csillag
force-pushed
the
csillag/more-white-labeling
branch
from
f9d12cb to
aee768e
Compare
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now web manifest,
og:imageand favicon can also be configured from.envObviously, when one wants to change the branding, the actual files still need to be added separately, but still, at least the "switching" between different brandings can be done in deployment config, making it easier to maintain multiple versions within the same repo.
(Which is exactly what we intend to do for Pontus-X, at least for the time being.)
Also, added
_META_to the name of some.enventries.