Add transparency to text highlight color #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/fix-text-highlight-transparency
branch
from
d7c6df6 to
fe53bca
Compare
buberdds
approved these changes
Feb 2, 2024
In order avoid the problem of hiding parts of the characters adjacent to the highlighted text, the highlighting background needs to be partially transparent.
csillag
force-pushed
the
csillag/fix-text-highlight-transparency
branch
from
fe53bca to
9ec1522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #646.
In order avoid the problem of hiding parts of the characters adjacent to the highlighted text, the highlighting background needs to be partially transparent.
For example, when highlighting "uma" in "Kumaji":
Before the fix:
The right part of the letter "K" is partially hidden.
After the fix: