-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide next/prev block buttons on mobile lists and search results #1219
Conversation
Deployed to Cloudflare Pages
|
@@ -89,8 +89,12 @@ export const BlockDetailView: FC<{ | |||
<dd> | |||
<BlockLink scope={block} height={block.round} /> | |||
<CopyToClipboard value={block.round.toString()} /> | |||
<PrevBlockButton scope={block} currentRound={block.round} /> | |||
<NextBlockButton scope={block} currentRound={block.round} /> | |||
{!standalone && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: https://5603e983.oasis-explorer.pages.dev/search?q=2%2C265%2C700
still appears on search results too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sidenote, i'm confused what standalone means.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect standalone to mean single block view, not the opposite https://5603e983.oasis-explorer.pages.dev/mainnet/sapphire/block/2265700
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hard to say what it means, but I think naming does not matter now. Let's fix buttons and imo let's refactor vertical tables to rely only on css. This way we will get rid of that prop (unless it is used in more contexts that I am not aware of)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added enableBlockNavigation
prop
5a79d75
to
234bff3
Compare
234bff3
to
2c031f2
Compare
Closes #1221