Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide next/prev block buttons on mobile lists and search results #1219

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Feb 1, 2024

Closes #1221

Copy link

github-actions bot commented Feb 1, 2024

Deployed to Cloudflare Pages

Latest commit: 2c031f2ddc9341358850109c41561f37f8efd76d
Status:✅ Deploy successful!
Preview URL: https://2a515e5d.oasis-explorer.pages.dev

@@ -89,8 +89,12 @@ export const BlockDetailView: FC<{
<dd>
<BlockLink scope={block} height={block.round} />
<CopyToClipboard value={block.round.toString()} />
<PrevBlockButton scope={block} currentRound={block.round} />
<NextBlockButton scope={block} currentRound={block.round} />
{!standalone && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: https://5603e983.oasis-explorer.pages.dev/search?q=2%2C265%2C700
still appears on search results too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sidenote, i'm confused what standalone means.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect standalone to mean single block view, not the opposite https://5603e983.oasis-explorer.pages.dev/mainnet/sapphire/block/2265700

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to say what it means, but I think naming does not matter now. Let's fix buttons and imo let's refactor vertical tables to rely only on css. This way we will get rid of that prop (unless it is used in more contexts that I am not aware of)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added enableBlockNavigation prop

@buberdds buberdds changed the title Hide next/prev block buttons on mobile lists Hide next/prev block buttons on mobile lists and search results Feb 1, 2024
@buberdds buberdds merged commit 7be380d into master Feb 1, 2024
8 checks passed
@buberdds buberdds deleted the mz/fixBlockButtons branch February 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Next/Previous block arrows appear on vertical list of blocks
2 participants