Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify search scopes and fix search on error pages #1159

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

Copy link

github-actions bot commented Jan 18, 2024

Deployed to Cloudflare Pages

Latest commit: 723d21a6185f039a9b968d42457168e9f37bcb74
Status:✅ Deploy successful!
Preview URL: https://7e5602ec.oasis-explorer.pages.dev

@lukaw3d lukaw3d force-pushed the lw/simplify-scopes branch from 9b1108d to f606344 Compare January 18, 2024 04:49
@csillag
Copy link
Contributor

csillag commented Jan 18, 2024

I have some relevant unpublished code, with the following goals:

  • Make it obvious that the scope we get from the URL might be invalid. (The valid flag is not there.)
  • Make a distinction between UncheckedScope (which might yet turn our to be invalid) and Scope (which must be valid) at the input of various components / functions.
  • Therefore, make in mandatory (on the typescript level) to apply the appropriate checks when we want to pass an unchecked scope to a component that can only handle a valid one. (This requires some code changes at multiple points int he codebase.)

I think this provides the ultimate protection against components being surprised by illegal data.

Unfortunately my latest implementation (according to the above plan) is still uncommited.

@lukaw3d I haven't checked your implementation yet, does it set the same goals?

@lukaw3d lukaw3d changed the title Simplify scopes Simplify scopes and recover from invalid URLs Jan 18, 2024
@lukaw3d lukaw3d force-pushed the lw/simplify-scopes branch from f606344 to 6cc668f Compare January 19, 2024 17:21
@lukaw3d lukaw3d enabled auto-merge January 19, 2024 17:21
@lukaw3d lukaw3d changed the title Simplify scopes and recover from invalid URLs Simplify search scopes and recover from invalid URLs Jan 19, 2024
@lukaw3d lukaw3d changed the title Simplify search scopes and recover from invalid URLs Simplify search scopes and fix search on error pages Jan 19, 2024
@lukaw3d lukaw3d force-pushed the lw/simplify-scopes branch from 6cc668f to 723d21a Compare January 19, 2024 17:37
@lukaw3d lukaw3d merged commit 719bce3 into master Jan 19, 2024
8 checks passed
@lukaw3d lukaw3d deleted the lw/simplify-scopes branch January 19, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants