-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify search scopes and fix search on error pages #1159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lukaw3d
force-pushed
the
lw/simplify-scopes
branch
from
January 18, 2024 04:49
9b1108d
to
f606344
Compare
I have some relevant unpublished code, with the following goals:
I think this provides the ultimate protection against components being surprised by illegal data. Unfortunately my latest implementation (according to the above plan) is still uncommited. @lukaw3d I haven't checked your implementation yet, does it set the same goals? |
lukaw3d
changed the title
Simplify scopes
Simplify scopes and recover from invalid URLs
Jan 18, 2024
buberdds
approved these changes
Jan 18, 2024
lukaw3d
force-pushed
the
lw/simplify-scopes
branch
from
January 19, 2024 17:21
f606344
to
6cc668f
Compare
lukaw3d
changed the title
Simplify scopes and recover from invalid URLs
Simplify search scopes and recover from invalid URLs
Jan 19, 2024
lukaw3d
changed the title
Simplify search scopes and recover from invalid URLs
Simplify search scopes and fix search on error pages
Jan 19, 2024
lukaw3d
force-pushed
the
lw/simplify-scopes
branch
from
January 19, 2024 17:37
6cc668f
to
723d21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1129 and #1157
Supersedes #1145 and #1146
I'm pretty sure this behaves the same way. @csillag @buberdds please check.
Do we have a list of edge-case URLs we can put into E2E tests?