Merge pull request #1412 from oasisprotocol/mz/fixKey

Fix React duplicated key warning in transactions list
oasisprotocol · May 14, 2024 · 409f2c3 · 409f2c3
2 parents 454f3eb + f844885
commit 409f2c3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.changelog/1412.bugfix.md b/.changelog/1412.bugfix.md
@@ -0,0 +1 @@
+Fix React duplicated key warning in transactions list
diff --git a/src/app/components/Transactions/ConsensusTransactions.tsx b/src/app/components/Transactions/ConsensusTransactions.tsx
@@ -57,7 +57,7 @@ export const ConsensusTransactions: FC<ConsensusTransactionsProps> = ({
       : []),
   ]
   const tableRows = transactions?.map(transaction => ({
-    key: transaction.hash,
+    key: `${transaction.hash}${transaction.index}`,
     data: [
       {
         content: <StatusIcon success={transaction.success} error={transaction.error} />,

diff --git a/src/app/components/Transactions/RuntimeTransactions.tsx b/src/app/components/Transactions/RuntimeTransactions.tsx
@@ -86,7 +86,7 @@ export const RuntimeTransactions: FC<TransactionsProps> = ({
   const tableRows = transactions?.map(transaction => {
     const targetAddress = transaction.to_eth || transaction.to
     return {
-      key: transaction.hash,
+      key: `${transaction.hash}${transaction.index}`,
       data: [
         {
           content: <StatusIcon success={transaction.success} error={transaction.error} />,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix React duplicated key warning in transactions list