ZigaMr/windows build support #342
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
.github/workflows/ci-tests.yml
Outdated
| - name: Build code | ||
| shell: pwsh | ||
| run: | | ||
| .\win_setup.ps1 build |
There was a problem hiding this comment.
Back slashes in YAML are considered escape characters. I would prefer ./win_setup.psi. Same below.
scripts/gen_example.ps1
Outdated
There was a problem hiding this comment.
gen_example script generates docs snippets and can be just executed on Linux. But we can keep it here for running the tests I suppose.
There was a problem hiding this comment.
Removed gen_example and win_setup, goreleaser now contains Windows build. Added option to cross-compile in Makefile.
Co-authored-by: Matevž Jekovec <[email protected]>
ZigaMr
force-pushed
the
ZigaMr/windows-build-support
branch
from
d5fd673 to
7d6929a
Compare
| @@ -48,3 +48,4 @@ jobs: | |||
| make clean-examples | |||
| make examples | |||
| git diff --exit-code examples | |||
|
|
|||
| @@ -74,6 +74,10 @@ clean: | |||
| rm -f oasis | |||
| $(GO) clean -testcache | |||
|
|
|||
| windows-build: | |||
There was a problem hiding this comment.
Move this up next to oasis. I hope find works under WSL.
| windows-build: | |
| oasis.exe: $(shell find . -name "*.go" -type f) go.sum go.mod |
Also add
build-windows: oasis.exe
below build.
| @@ -83,3 +87,4 @@ clean: | |||
| $(lint-targets) lint \ | |||
| $(test-targets) test \ | |||
| clean | |||
| windows | |||
There was a problem hiding this comment.
Let's call this build-windows and move it up next to build.
|
Please update the description of this PR to reflect the updated version and don't forget to squash the commits. |
This PR adds PowerShell scripts as an alternative to the Makefile. The scripts maintain feature parity with the Makefile and accept the same command-line parameters, allowing Windows users to run identical commands.
Workflows: Updated ci-test.yml with windows image.