Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/genesis: The tests aren't actually being ran at all #2589

Closed
Yawning opened this issue Jan 23, 2020 · 1 comment · Fixed by #2612
Closed

go/genesis: The tests aren't actually being ran at all #2589

Yawning opened this issue Jan 23, 2020 · 1 comment · Fixed by #2612
Assignees
Labels
c:bug Category: bug c:testing Category: testing golang

Comments

@Yawning
Copy link
Contributor

Yawning commented Jan 23, 2020

Nothing actually calls the genesis document tests that live under go/genesis/tests.

There isn't really a reason why they need to live in a separate test driver either (unlike the consensus backed tests) since the test document should be consensus backend agnostic, so maybe refactor the tests out to go/genesis/genesis_tests.go.

Additionally, due to the tests not being ran at all, the test cases have rotted, and need to be fixed.

@Yawning Yawning added c:testing Category: testing golang c:bug Category: bug labels Jan 23, 2020
@kostko
Copy link
Member

kostko commented Jan 23, 2020

Ooops :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:testing Category: testing golang
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants