Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis SanityCheck Addresses once existing deployments have cleaned up registry #2428

Closed
ptrus opened this issue Nov 26, 2019 · 1 comment · Fixed by #2575
Closed

Genesis SanityCheck Addresses once existing deployments have cleaned up registry #2428

ptrus opened this issue Nov 26, 2019 · 1 comment · Fixed by #2575
Assignees
Labels
c:registry Category: entity/node/runtime registry service

Comments

@ptrus
Copy link
Member

ptrus commented Nov 26, 2019

Since existing deployments currently include invalid P2P.IDs and addresses we cannot yet sanity check those fields in genesis as it would prevent doing a import/export deployment. After next deployment, check if registry state is ok and can be sanity checked.

Validate P2P.ID and Consensus/Committee/P2P addresses after existing deployments have cleared up registry.

@kostko
Copy link
Member

kostko commented Jan 14, 2020

While here, we should also deduplicate the node descriptor checks, possibly by having the registry doc's SanityCheck call VerifyRegisterNodeArgs.

@kostko kostko added the c:registry Category: entity/node/runtime registry service label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:registry Category: entity/node/runtime registry service
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants