Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-sound: add latency_bytes definition #198

Open
MatiasVara opened this issue Jun 21, 2024 · 2 comments
Open

virtio-sound: add latency_bytes definition #198

MatiasVara opened this issue Jun 21, 2024 · 2 comments

Comments

@MatiasVara
Copy link

MatiasVara commented Jun 21, 2024

Section 5.14.6.8 PCM I/O Messages defines the latency_bytes field that is used by the device to inform the driver the latency in terms of bytes until a buffer is played or has been captured. However, the specification does not describe this mechanism very well. We propose to improve the existing description with a better one based on the comment at https://github.com/google/crosvm/blob/main/common/audio_streams/src/audio_streams.rs#L380C9-L380C96 and the discussion we had at https://lore.kernel.org/all/ZR6EzpQb6J1TxbM8@fedora/T/.

Fix: https://lore.kernel.org/virtio-comment/Zky3vZU+P37H4VPb@fedora/

@mstsirkin
Copy link
Contributor

mstsirkin commented Jun 21, 2024

@MatiasVara please edit the issue to add a bit more detail:

  • include description of the issue
  • include short summary of the proposal

@MatiasVara
Copy link
Author

@MatiasVara please edit the issue to add a bit more detail:

  • include description of the issue
  • include short summary of the proposal

Hello @mstsirkin I just updated the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants