This repository has been archived by the owner on May 11, 2020. It is now read-only.
Fixin stuff #4
Merged
Fixin stuff #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 8, 2018 13:18
If the role is unable to detect which connection manages the given interface, fail with a better error than 'Error: unknown connection "--"' closes oasis-roles#3
In the process of actually using this role, I was reminded that it exists mainly to address a bit of an edge case, which is to be able to add an address to an interface after that interface has already been configured (e.g. after installing a system that receives addresses via DHCP, this role can be used to add an additional static address to that interface).
|
downstream jenkins appears to be generally failing due to an pytest regression, which is in the process of being fixed: pytest-dev/pytest#4304 Test output show that the tests passed before pytest exploded. I'm content to wait for the pytest fix to roll out, but if we want to fix it right now, we could pin pytest to 3.9.3, the most recent release prior to the regression. |
|
This comment contains a specific fix for molecule, which is handy, should this problem persist. :) |
|
ok build |
|
The downstream tests are failing in automation due to an odd pipeline bug, but the molecule scenario works when run directly. (oasis-origin/oasis-pipeline#1) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three separate commits: