Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip unallowed common properties provided by ObjectFactory #606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip unallowed common properties provided by ObjectFactory #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions stix2/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ def create(self, cls, **kwargs):
# Use self.defaults as the base, but update with any explicit args
# provided by the user.
properties = copy.deepcopy(self._defaults)

# SCOs do not have these common properties provided by the factory
if "observables" in cls.__module__:
properties.pop("created", None)
properties.pop("created_by_ref", None)
properties.pop("external_references", None)

if kwargs:
if self._list_append:
# Append provided items to list properties instead of replacing them
Expand Down