Similarity/Equivalence Changes #496

emmanvg · 2021-03-01T19:13:24Z

Expose algorithm configuration right on the calls
Provide ability in object similarity/equivalence to de-reference objects via DataStores, or equality check when not provided
Update documentation and guide

clenk

Looks great for the most part; just a couple comments.

stix2/test/v21/test_environment.py

stix2/equivalence/object/__init__.py

stix2/environment.py

Co-authored-by: Chris Lenk <[email protected]>

…) and object_equivalence()

clenk

Thank you @emmanvg!

emmanvg added 6 commits February 26, 2021 19:19

WIP: changes to both similarity functions, expose settings

f9a52ee

expose configuration options, combine weight dictionary, update tests

ff5014c

docstring corrections

d2e867b

revert part changes

3efa4c1

change key name for _refs check

e4e6f46

update guide example, conf.py and remove some unused imports

72a12e9

emmanvg added this to the 3.0.0 milestone Mar 1, 2021

Update __init__.py

bd996b8

clenk suggested changes Mar 5, 2021

View reviewed changes

emmanvg commented Mar 10, 2021

View reviewed changes

stix2/environment.py Outdated Show resolved Hide resolved

emmanvg and others added 3 commits March 10, 2021 09:52

Update stix2/environment.py

2622844

Co-authored-by: Chris Lenk <[email protected]>

Update stix2/environment.py

7d7c56c

rename test, update the rest of the docstrings for object_similarity(…

c9e66de

…) and object_equivalence()

emmanvg requested a review from clenk March 10, 2021 18:50

clenk approved these changes Mar 10, 2021

View reviewed changes

clenk merged commit f155e3e into oasis-open:master Mar 10, 2021

emmanvg deleted the semantic-equivalence-part3 branch March 10, 2021 21:47

Provide feedback